Allow access for non-registered users #475
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dzikowski <[email protected]>
dzikowski
commented
Dec 19, 2024
Comment on lines
-70
to
+68
| // will throw error for legacy auth if the addr is missing | ||
| const address = dto.signing === SigningScheme.TON ? ctx.callingUserTonAddress : ctx.callingUserEthAddress; | ||
| const profile = await PublicKeyService.getUserProfile(ctx, address); | ||
|
|
||
| if (profile === undefined) { | ||
| throw new NotFoundError(`UserProfile not found for ${ctx.callingUser}`, { | ||
| signature: dto.signature, | ||
| user: ctx.callingUser | ||
| }); | ||
| } | ||
|
|
||
| return profile; | ||
| return ctx.callingUserProfile; |
There was a problem hiding this comment.
this way we can also return default profile here
dzikowski
changed the title
…ional feature Signed-off-by: Jakub Dzikowski <[email protected]>
Signed-off-by: Jakub Dzikowski <[email protected]>
…egister methods and provide example for allowing non-registered users Signed-off-by: Jakub Dzikowski <[email protected]>
dzikowski
commented
Jan 13, 2025
Comment on lines
140
to
146
| if (profile === undefined) { | ||
| throw new UserNotRegisteredError(address); | ||
| if (ctx.config.allowNonRegisteredUsers) { | ||
| return PublicKeyService.getDefaultUserProfile(publicKey, signing); | ||
| } else { | ||
| throw new UserNotRegisteredError(address); | ||
| } | ||
| } |
There was a problem hiding this comment.
this is the location where we make use of the feature flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.