Align recently added features with SDK v2 conventions #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dzikowski <[email protected]>
Signed-off-by: Jakub Dzikowski <[email protected]>
- Updated `BurnAndMintDto` to extend `SubmitCallDTO` instead of `ChainCallDTO`. - Made `roles` in `UserProfile` optional and updated related types to ensure consistency. - Changed `identityKey` in `ChainUserAPI` to use `UserAlias`. - Adjusted user role handling in various tests and services to accommodate the new optional roles structure. - Updated return types in `getUserProfile` functions to use `UserProfileWithRoles` for better type safety. These changes enhance type safety and align the code with the latest SDK conventions. Signed-off-by: Jakub Dzikowski <[email protected]>
Signed-off-by: Jakub Dzikowski <[email protected]>
- Updated multiple DTOs (RequestTokenBridgeOutDto, OraclePriceCrossRateAssertionDto, OracleBridgeFeeAssertionDto) to extend SubmitCallDTO instead of ChainCallDTO - Modified GalaTransaction authentication logic to handle default roles more flexibly - Adjusted condition order in burnTokens function for better readability - Removed unused import in validateMintRequest These changes continue the ongoing refactoring to align with SDK v2 conventions and improve type safety. Signed-off-by: Jakub Dzikowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.