Fix ci jobs when unify version #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuerback
changed the title
dzikowski
approved these changes
Feb 26, 2024
| @@ -1,7 +1,6 @@ | |||
| name: CI | |||
| on: | |||
| push: | |||
| branches: ['**'] | |||
There was a problem hiding this comment.
is it safe to remove it?
There was a problem hiding this comment.
It's duplicating the job executions after we added the pull_request.
My understanding is that we should choose which one we want to keep, for every branch (and it includes pull requests) or only when a pull request is created.
|
|
||
| # chaincode-template-lint: |
There was a problem hiding this comment.
There is no more comment line in ci.yml.
herr-bubu
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
Chaincode Template Lintjob whenunifyVersions.jsis executed.It also updates the
unifyVersions.jsto update a few files (e.g. licenses, lock, oclif manifest) after update thepackage.jsonfiles.