Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 Log model version information when a model is loaded from the registry (#552) #588

Merged
merged 8 commits into from
Oct 26, 2024

Conversation

Galileo-Galilei
Copy link
Owner

Description

Close #552

Development notes

What have you changed, and how has this been tested?

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@Galileo-Galilei
Copy link
Owner Author

This could help: mlflow/mlflow#10459 (comment)

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (d6758ac) to head (e559cdb).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          29       29           
  Lines        1038     1044    +6     
=======================================
+ Hits         1037     1043    +6     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Galileo-Galilei Galileo-Galilei marked this pull request as ready for review October 26, 2024 13:17
@Galileo-Galilei Galileo-Galilei merged commit 8f8f6aa into master Oct 26, 2024
2 of 16 checks passed
@Galileo-Galilei Galileo-Galilei deleted the 552-model-version branch October 26, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show loaded model version in logs
2 participants