Fix IEEE 754 comparison ((>) and (>=)) for BigFloat when NaN is involved #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the
(>)
and(>=)
operator of theBigFloat
, which aren't IEEE 754 complaint whenNaN
is involved.The original implementation relies on the default implementation of the
(>)
and(>=)
. Unfortunately, the base library implemented them as negation of(<)
and(<=)
, which would makenan > 1
or1 > nan
evaluate toTrue
.