symbolic: Factor stack setup code into its own module #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several Macaw-based projects use a similar stack setup: * `pate`: https://github.com/GaloisInc/pate/blob/c43542818be7780264d8a2552bfeba1cffba2902/src/Pate/Verification/InlineCallee.hs#L135-L143 * `ambient-verifier`: https://github.com/GaloisInc/ambient-verifier/blob/open-source/src/Ambient/Verifier/SymbolicExecution.hs#L1272-L1280 We can share code by factoring it into its own module.
langston-barrett
force-pushed
the
lb/stack-model
branch
from
68bfd38
to
70227cf
Compare
dbb4c83 introduced this stack-pointer-in-the-middle approach, but the commit message has no further commentary on why it was seen as necessary. I've written up why *I* believe it to be necessary, and removed what I see as a misleading comment. Also, return a pointer to the end of the stack, because that's what most clients will want.
langston-barrett
force-pushed
the
lb/stack-model
branch
from
70227cf
to
06b5ce3
Compare
langston-barrett
changed the title
RyanGlScott
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factors some code out of
Testinginto its own module for the sake of clarity and code-sharing. Several downstream projects could benefit from this API, see #430 for examples.Also, rewrites a comment that I believe to have been misleading.