Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mfkey32: fix result inconsistency with cli #254

Merged
merged 1 commit into from
Sep 10, 2023
Merged

mfkey32: fix result inconsistency with cli #254

merged 1 commit into from
Sep 10, 2023

Conversation

hank9999
Copy link
Contributor

mfkey32: fix result inconsistency with cli
fix detection data incomplete getting
fix mf1GetDetectionResult command data wrong type (from Int16 to Int32)

Copy link
Collaborator

@Foxushka Foxushka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely don't like how you did it

chameleonultragui/lib/gui/page/mfkey32.dart Outdated Show resolved Hide resolved
chameleonultragui/lib/gui/page/mfkey32.dart Outdated Show resolved Hide resolved
chameleonultragui/lib/gui/page/mfkey32.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@Foxushka Foxushka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, wrong button

@hank9999
Copy link
Contributor Author

Completely don't like how you did it

Sorry about that, I am new in Flutter and Dart. I will force update asap.

fix detection data incomplete getting
fix mf1GetDetectionResult command data wrong type (from Int16 to Int32)
Copy link
Collaborator

@Foxushka Foxushka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Foxushka Foxushka merged commit 8608613 into GameTec-live:main Sep 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants