Skip to content

Commit

Permalink
Merge pull request #913 from carstingaxion/fix/dry-out-screenshot-wor…
Browse files Browse the repository at this point in the history
…kflow-args

DRY out WP_BASE_URL definition into package.json
  • Loading branch information
carstingaxion authored Sep 24, 2024
2 parents 1010348 + 697a5e4 commit 836ba22
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
6 changes: 2 additions & 4 deletions .github/workflows/wordpress-org-screenshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ jobs:
npm run playground -- --blueprint=./localized_blueprint.json & \
sleep 60 && \
echo 'Playground is ready now, lets take some pictures.' && \
WP_BASE_URL='http://127.0.0.1:9400/' \
DEBUG=pw:api,pw:webserver \
# DEBUG=pw:api,pw:webserver \
npm run screenshots:wporg
- name: Updating the Screenshots
Expand All @@ -166,8 +165,7 @@ jobs:
npm run playground -- --blueprint=./localized_blueprint.json & \
sleep 60 && \
echo 'Playground is ready now, lets take some pictures.' && \
WP_BASE_URL='http://127.0.0.1:9400/' \
DEBUG=pw:api,pw:webserver \
# DEBUG=pw:api,pw:webserver \
npm run screenshots:wporg -- --update-snapshots
- name: Commit updated screenshots
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,9 @@
"packages-update": "wp-scripts packages-update",
"plugin-zip": "wp-scripts plugin-zip",
"start": "wp-scripts start",
"screenshots:wporg": "wp-scripts test-playwright --config .github/scripts/wordpress-org-screenshots/playwright.config.ts",
"screenshots:wporg:debug": "wp-scripts test-playwright --config .github/scripts/wordpress-org-screenshots/playwright.config.ts --debug",
"screenshots:wporg:ui": "wp-scripts test-playwright --config .github/scripts/wordpress-org-screenshots/playwright.config.ts --ui",
"screenshots:wporg": "WP_BASE_URL='http://127.0.0.1:9400/' wp-scripts test-playwright --config .github/scripts/wordpress-org-screenshots/playwright.config.ts",
"screenshots:wporg:debug": "npm run screenshots:wporg -- --debug",
"screenshots:wporg:ui": "npm run screenshots:wporg -- --ui",
"test:e2e": "playwright test --config=playwright.config.js",
"test:unit:js": "wp-scripts test-unit-js --coverage --testResultsProcessor=jest-sonar-reporter",
"pretest:unit:php": "wp-env start --xdebug",
Expand Down

0 comments on commit 836ba22

Please sign in to comment.