Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_taxonomy_registration_args method from event and venue cla… #565

Merged
merged 5 commits into from
Feb 25, 2024

Conversation

mauteri
Copy link
Contributor

@mauteri mauteri commented Feb 23, 2024

Description of the Change

This is a refactor of code and some changing of responsibilities.

  • Removed get_taxonomy_registration_args methods and handled post type/taxonomy/post meta registrations in related classes, not setup class.
  • Created Topic class to manage that taxonomy outside the Event class.
  • Created Event_Setup class to handle registration and event functionality that affects event setups outside of individual events. This removes some odd static methods from the Event class and lets it behave as an instance of a single event.
  • Moved some static methods out of Event class and into Utility class where they make more sense.
  • Added and update unit test.

Closes #564 #563

How to test the Change

Code should function same as it had before.

Changelog Entry

Changed - Existing functionality

Credits

Props @mauteri

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@mauteri mauteri marked this pull request as draft February 23, 2024 17:26
@mauteri mauteri marked this pull request as ready for review February 25, 2024 02:08
@mauteri mauteri merged commit a71446b into main Feb 25, 2024
10 checks passed
@mauteri mauteri deleted the GP-564 branch February 25, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird ´get_taxonomy_registration_args()´
1 participant