Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wpcli i18n tooling #585

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

carstingaxion
Copy link
Collaborator

As a translation contributor it is super-handy to use the i18n-tooling, that is included in wp-cli by default. So I would suggest adding it, at least to the development-requirements for GatherPress.

But ... how to install wp-cli is heavily different depending on the system, you want to run it on. This is well documented at Installing – WP-CLI – WordPress.org. That's why we can not or should not just add it it to GatherPress' composer dependencies.

Description of the Change

This PR only suggests the wp-cli package via composer.josn, but leaves the decision open on how and where to install it.

Assuming wp-cli is installed now per the suggestion within the dev environment, someone can now use three new scripts to create translation files for GatherPress.

npm run i18n:pot
npm run i18n:json
npm run i18n:php

The third script provides access to the new performant translations functionality, introduced in WP 6.5 and already mentioned by @patriciabt over here.

Closes #

How to test the Change

...

Changelog Entry

Added - i18n tooling by wp-cli

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@carstingaxion
Copy link
Collaborator Author

Seems, we need to exclude the newly generated performant translation files from the CS checks.

@mauteri
Copy link
Contributor

mauteri commented Mar 6, 2024

Seems, we need to exclude the newly generated performant translation files from the CS checks.

Just committed change for that for you.

@mauteri mauteri merged commit 1d7511d into GatherPress:main Mar 6, 2024
9 of 10 checks passed
@carstingaxion
Copy link
Collaborator Author

Incredible, how fast you were @mauteri. Thanks!

@carstingaxion carstingaxion deleted the feature/wpcli-i18n-tooling branch March 6, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants