Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve translations #588

Merged
merged 11 commits into from
Mar 7, 2024

Conversation

carstingaxion
Copy link
Collaborator

@carstingaxion carstingaxion commented Mar 6, 2024

Description of the Change

This PR fixes four little bugs according to the translation handling of some strings.

  1. Dateformat of datetime block is not translated/translatable
    I think @patriciabt mentioned this as well. Not sure if a ticket was created though.
    (from Purpose, bug or room for enhancements #557)

  2. Allow for easier translation #551
  3. Allow for easier translation #551
  4. Allow for easier translation #551

Closes #551

How to test the Change

Changes can be seen & tested, when the translations are updated, so every translation contributor is happily invited to:

  1. Update their .po files from the updated .pot file
  2. Update and add translations
  3. Run npm run i18n:json
  4. Run npm run i18n:php

(This should be an issue, on its own ... i feel it)

Changelog Entry

Fixed - Render translated version of date-time-block also within the editor and simplify translation of (some) strings

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

what-the-diff bot commented Mar 6, 2024

PR Summary

  • Update of date and time translation string in edit.js
    The translation string used for displaying date and time format in the edit.js file located in src/blocks/event-date was modified. The updated string now includes the word 'gatherpress', improving the clarity of data displayed.

This change will contribute to a clearer display of date and time information, improving the overall usage experience.

@carstingaxion
Copy link
Collaborator Author

I'm really sorry for this messed up commit history. May the git god forgive me.

@carstingaxion carstingaxion marked this pull request as ready for review March 7, 2024 10:25
@carstingaxion carstingaxion changed the title Add missing textdomain string to also show the translated string within the editor. Improve translations Mar 7, 2024
Copy link
Contributor

@mauteri mauteri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mauteri mauteri merged commit 1c19f2f into GatherPress:main Mar 7, 2024
10 checks passed
@carstingaxion carstingaxion deleted the feature/i18n-improvements branch March 12, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for easier translation
2 participants