-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve translations #588
Merged
mauteri
merged 11 commits into
GatherPress:main
from
carstingaxion:feature/i18n-improvements
Mar 7, 2024
Merged
Improve translations #588
mauteri
merged 11 commits into
GatherPress:main
from
carstingaxion:feature/i18n-improvements
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR Summary
This change will contribute to a clearer display of date and time information, improving the overall usage experience. |
I'm really sorry for this messed up commit history. May the git god forgive me. |
carstingaxion
changed the title
Add missing textdomain string to also show the translated string within the editor.
Improve translations
Mar 7, 2024
14 tasks
mauteri
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR fixes four little bugs according to the translation handling of some strings.
Closes #551
How to test the Change
Changes can be seen & tested, when the translations are updated, so every translation contributor is happily invited to:
npm run i18n:json
npm run i18n:php
(This should be an issue, on its own ... i feel it)
Changelog Entry
Credits
Props @carstingaxion
Checklist: