Event date block and functionality refactor #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime endpoint many times on save rather than just once.
mauteri
commented
Aug 27, 2024
mauteri
commented
Aug 27, 2024
|
@mauteri Do not miss to checkout the work at WordPress/gutenberg#60971, which seems closely related to GatherPress' needs for a close-to-core event date block. |
Yup, saw this but it's still in the design phase. If this makes it into core we can definitely swap out the picker. |
…stener functionality.
… custom table in meta action.
Preview changes with PlaygroundYou can preview the least recent changes for PR#820 by following one of the links below: |
mauteri
changed the title
bluecollarcoders
approved these changes
Sep 11, 2024
jmarx
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change updates the Event Date block to look and feel more like the WordPress core date block in terms of styling. In this PR we also introduce meta data that is available in core post REST API for datetime start, end, and timezone. We also use meta data hook to update the custom event table for datetimes. This means we no longer need the datetime REST endpoint which was a bit clunky and required an additional call. That endpoint has now been removed. In addition, WP core stores powered by redux were introduced to start replacing the Broadcaster/Listener code that was custom written. This works a LOT better, and soon more things will get stores to replace Broadcaster/Listener functionality.
Closes #803 #684
How to test the Change
Changelog Entry
Credits
Props @mauteri
Checklist: