Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate screenshot generator workflow to use wp-playground/cli #822

Conversation

carstingaxion
Copy link
Collaborator

@carstingaxion carstingaxion commented Aug 27, 2024

Description of the Change

Use WordPress Playground in favor of wp-env as the environment for the screenshot generator.

Switching to Playground not only makes this workflow a lot faster, it also allows to use a blueprint.json to setup the environment, which is way more comfortable, than writing a long list of wp-cli commands to do the same.

Needed before merge

Included in this PR is also:

  • the subtle change to use the modern Admin-UI,
    which should become the default across all GatherPress Playgrounds
  • hiding the admin-notices for this presentation-purpose, like @patriciabt suggested
  • fixing the left sided menu background to fill the full height of the screen

grafik

Closes #

How to test the Change

Changelog Entry

Changed - Run the screenshot generator workflow on WordPress Playground

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@carstingaxion carstingaxion mentioned this pull request Aug 27, 2024
62 tasks
@carstingaxion carstingaxion self-assigned this Aug 28, 2024
@carstingaxion carstingaxion mentioned this pull request Sep 2, 2024
4 tasks
@carstingaxion
Copy link
Collaborator Author

I splitted this into #837 and #838 for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant