Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest stable plugin version (not dev) to generate screenshots from #847

Conversation

carstingaxion
Copy link
Collaborator

@carstingaxion carstingaxion commented Sep 3, 2024

Screenshots are made from released versions only

Running this workflow from an unpublished development release leads to 404s on all language packs

https://downloads.wordpress.org/translation/plugin/gatherpress/0.31.0-alpha/fr_FR.zip

Description of the Change

Thats why we grab the latest release directly from wp.org, which makes sure the existing translations will match the loaded codebase.

Alternatives

We could instantly rewrite the version numbers in .php and .md file to match the latest stable version.
This would allow downloads.wordpress.org/translation to find and load the translation files. But it could be that parts of the plugin will not be translated or not be as accurate as on the last stable.

# Closes an undocumented problem with the new wp-playground/cli powered screenshot generator.

How to test the Change

Lets start the workflow and lets see if french UI, will be really french UI !

Changelog Entry

Changed - Screenshots are gonna made from released versions only

Credits

Props @carstingaxion

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@carstingaxion carstingaxion changed the title Use latest stable plugin version (not dev) to genearte screenshots Use latest stable plugin version (not dev) to generate screenshots from Sep 3, 2024
@carstingaxion carstingaxion marked this pull request as ready for review September 3, 2024 21:03
@carstingaxion carstingaxion merged commit 9ee889e into GatherPress:main Sep 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant