Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH RELEASE 0.30.1 — Allow to create nice screenshots from 0.30.0 #862

Closed

Conversation

carstingaxion
Copy link
Collaborator

@carstingaxion carstingaxion commented Sep 5, 2024

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

what-the-diff bot commented Sep 5, 2024

PR Summary

  • Enhancements to the check_users_can_register() function
    The code has been updated to include a new condition. This checks if the 'GATHERPRESS_ALPHA_VERSION' constant is present, ensuring the function operates correctly under specific circumstances.

Copy link

github-actions bot commented Sep 5, 2024

Preview changes with Playground

You can preview the least recent changes for PR#862 by following one of the links below:

⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carstingaxion carstingaxion marked this pull request as ready for review September 5, 2024 13:59
@mauteri
Copy link
Contributor

mauteri commented Sep 7, 2024

Not sure I agree on a release just for this. It means we need to package up a release for both the plugin and GatherPress Alpha, which will then make the user have to update GatherPress Alpha on their site as well. If we have any other small release we want to make I would include this, but I wouldn't make 0.30.1 just this.

@carstingaxion
Copy link
Collaborator Author

Yes, I haven’t seen the full picture, which is slightly more complicated.

Even I’m unsure if I like this tight coupling, I’m ok with waiting or even closing this PR.

@mauteri
Copy link
Contributor

mauteri commented Sep 7, 2024

We can keep it open for now and see if there are other changes we need to make in 0.30.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants