(solves 736) Checkbox to toggle latitude and longitude in Venue block #877
Conversation
|
I tested your work the first time, and it showed the UI nicely. Unfortunately, the current set of demo-data has no lat lng data. Wasn’t there an idea in the past to request missing data on the fly to help with backwards compatibility? Next to that, I would prefer to have this fields in the Venue Settings, rather than in the map settings, as the data belongs to the venue, not the kind of map rendering. |
src/blocks/venue/edit.js
Outdated
| </PanelRow> | ||
| {mapCustomLatLng && ( | ||
| <> | ||
| <TextControl |
There was a problem hiding this comment.
Let's make this a NumberControl
import { __experimentalNumberControl as NumberControl } from '@wordpress/components';
src/blocks/venue/edit.js
Outdated
| updateVenueMeta({ latitude: value }); | ||
| }} | ||
| /> | ||
| <TextControl |
There was a problem hiding this comment.
NumberControl here too. If you leave this as TextControl, hitting a non-number crashes the block.
| Broadcaster({ setLongitude: value }); | ||
| updateVenueMeta({ longitude: value }); | ||
| }} | ||
| /> |
There was a problem hiding this comment.
We should have a button that will "Reset" the coordinates. Just call the button "Reset" and have it take the address and run it through the API again to bring back original values.
There was a problem hiding this comment.
Seems that the changes in lat/long are not being retained. I did some updates, but I don't think anything that should have effected functionality. It changes, but then when I leave focus, it reverts... It might be good to use the redux stores rather than Broadcaster/Listener as that may be the issue.
There was a problem hiding this comment.
We should have a button that will "Reset" the coordinates. Just call the button "Reset" and have it take the address and run it through the API again to bring back original values.
toggling default/custom will now reset the map in way you are describing.
@mauteri
There was a problem hiding this comment.
Seems that the changes in lat/long are not being retained. I did some updates, but I don't think anything that should have effected functionality. It changes, but then when I leave focus, it reverts... It might be good to use the redux stores rather than Broadcaster/Listener as that may be the issue.
We implemented the store. So all these issues should be resolved. @mauteri
There was a problem hiding this comment.
@jmarx I would like to add the Reset button. I get what you are saying, but that might not be super obvious to people. A reset button would be.
src/blocks/venue/edit.js
Outdated
| @@ -23,7 +25,7 @@ import { isVenuePostType } from '../../helpers/venue'; | |||
| import VenueSelector from '../../components/VenueSelector'; | |||
| import VenueInformation from '../../panels/venue-settings/venue-information'; | |||
| import OnlineEventLink from '../../components/OnlineEventLink'; | |||
| import { Listener } from '../../helpers/broadcasting'; | |||
| import { Broadcaster, Listener } from '../../helpers/broadcasting'; | |||
There was a problem hiding this comment.
If you'd like to look at the store I created for updates to the Event Date block, you can start using that instead of the Listener / Broadcaster. If not, we can update to that later.
There was a problem hiding this comment.
If you'd like to look at the
storeI created for updates to theEvent Dateblock, you can start using that instead of theListener / Broadcaster. If not, we can update to that later.
@mauteri Done.
| Broadcaster({ setLongitude: value }); | ||
| updateVenueMeta({ longitude: value }); | ||
| }} | ||
| /> |
There was a problem hiding this comment.
Seems that the changes in lat/long are not being retained. I did some updates, but I don't think anything that should have effected functionality. It changes, but then when I leave focus, it reverts... It might be good to use the redux stores rather than Broadcaster/Listener as that may be the issue.
|
@mauteri We are pretty close on this. Everything works well with OSM. But we just need to make another adjustment for Google Maps. But feel free to take another pass at this and check out our implementation of the redux store. Please let me know if anything needs to be changes with that. Also, |
stephenerdelyi
changed the title
Preview changes with PlaygroundYou can preview the recent changes for PR#877 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
Description of the Change
Closes #736
How to test the Change
Changelog Entry
Credits
Props @stephenerdelyi , @jmarx
Checklist: