Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Event->get_formatted_datetime() method public #878

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Make Event->get_formatted_datetime() method public #878

merged 2 commits into from
Sep 17, 2024

Conversation

JordanPak
Copy link
Contributor

@JordanPak JordanPak commented Sep 17, 2024 •
edited
Loading

Description of the Change

Closes #635

How to test the Change

Changelog Entry

Changed - Made GatherPress\Core\Event's get_formatted_datetime() and get_calendar_description() methods public (from protected).

Credits

Props @JordanPak

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@github-actions GitHub Actions
Copy link

Preview changes with Playground

You can preview the least recent changes for PR#878 by following one of the links below:

⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@JordanPak JordanPak marked this pull request as ready for review September 17, 2024 17:54
@carstingaxion
Copy link
Collaborator

😆 Did the same (again in) #831.

@mauteri mauteri merged commit 7b597be into GatherPress:main Sep 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mauteri mauteri mauteri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make some protected methods public
3 participants
@JordanPak @carstingaxion @mauteri