-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW unit tests for the Import & Export classes #937
NEW unit tests for the Import & Export classes #937
Conversation
PR Summary
|
Hello @mauteri , can you please help me here, please? I'm wondering if the failing unit-test should be fixed rather in What do you think? |
*/ | ||
protected function validate( WP_Post $post ): bool { | ||
return ( Event::POST_TYPE === $post->post_type ); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add this to the new Validate
class. Validate::event_post_type( $post )
https://github.com/GatherPress/gatherpress/blob/develop/includes/core/classes/class-validate.php
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never mind, we can use Validate::event_post_id
here.
Preview changes with PlaygroundYou can preview the recent changes for PR#937 with the following PHP versions: PHP Version 8.3
PHP Version 7.4
Download Made with 💙 from GatherPress & a little bit of WordPress Playground. Changes will not persist between sessions. |
Description of the Change
Closes #How to test the Change
Changelog Entry
Credits
Props @carstingaxion @mauteri
Checklist: