Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gathepress venue #968

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Prayag11
Copy link
Contributor

Description of the Change

Closes #

How to test the Change

Changelog Entry

Added - New feature
Changed - Existing functionality
Deprecated - Soon-to-be removed feature
Removed - Feature
Fixed - Bug fix
Security - Vulnerability

Credits

Props @username, @username2, ...

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link

what-the-diff bot commented Dec 24, 2024

PR Summary

  • New Test File for Venue Map Verification
    A new end-to-end test file has been added that aids in verifying the venue map on the admin side.

  • Username Update in Tests
    The username in the existing tests has been updated from 'testuser1' to 'prashantbellad' for better reliability.

  • New Test File for Event Location Visibility Verification
    A new test has been introduced to verify the visibility of the event location in the venue post.

  • Tests to Check Venue Map Visibility with Toggle Switch
    New tests have been added that evaluate the visibility of the venue map when the toggle switch is turned ON and OFF.

  • Minimal Additions in the Event Creation Flow
    Minor adjustments have been made in the event creation flow in the gatherpress-event-loggedIn.spec.js file to enhance the user experience.

  • Use of .js Extension in Module Imports
    To maintain consistency, module imports in multiple files now use the .js extension.

  • Map Visibility Verification after Event Creation
    A new test has been added to verify the visibility of the map following the creation of the event.

  • Modification in Venue Selector Option Passing
    The method of passing the venue Selector option in event tests has been modified for events that have been newly created. This optimizes the system’s overall functionality.

@mauteri
Copy link
Contributor

mauteri commented Dec 24, 2024

@Prayag11 you can run npm run lint:js:fix to fix JS issues automatically. You can also run npm run lint:js to just see what the issues are so you can fix some manually that can't be fixed automatically. All of the commands are listed in package.json that can help you with development. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants