Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add a feature to support checks of the GitHub issue tracker #126

Open
wants to merge 48 commits into
base: master
Choose a base branch
from

Conversation

baldeosinghm
Copy link
Contributor

@baldeosinghm baldeosinghm commented Mar 14, 2019

This PR will allow for students to check for which issues were checked, discussed and closed. It also handles errors for repositories and incorrect issues numbers.

@ZachAndrews98 @yeej2 @baldeosinghm

Fixes #76.

Maintainer Note: This PR is on hold until GatorGradle or other supporting software can support GitHub authentication.

@gkapfham gkapfham requested review from schultzh and removed request for finneyj2 April 5, 2019 19:02
@Michionlion Michionlion added feature on-hold This PR or issue may be handled in the future labels Apr 5, 2019
@gkapfham
Copy link
Collaborator

gkapfham commented Apr 6, 2019

Hello @baldeosinghm and @ZachAndrews98 and @yeej2, thanks for creating this PR. For now, @Michionlion and I have decided that we cannot merge it until we develop a better path forward for allowing secure authentication. Our view is that your implementation defines a great approach and foundation for this feature.

However, we are concerned that the limitation to public repositories is too limiting for this feature and, moreover, that we are not sure what is the best way to move forward with the authentication.

If you have ideas on how to improve this feature, please let us know. Otherwise, we are going to leave this PR open until we can do further research and then identify a feasible and secure solution.

@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@GatorEducator GatorEducator deleted a comment Apr 18, 2019
@gkapfham gkapfham changed the title Add a feature to support checks of the GitHub issue tracker WIP: Add a feature to support checks of the GitHub issue tracker May 27, 2019
@baldeosinghm
Copy link
Contributor Author

Due to the unfeasible nature of this task that withholds us from granting authentication without prying into user information, we will be closing this PR.

@gkapfham gkapfham reopened this Jun 14, 2019
@gkapfham
Copy link
Collaborator

gkapfham commented Jul 6, 2019

I have left this issue open, but it is on hold. It will be difficult to merge this into the master branch given that the GatorGrader system has evolved significantly since this PR was started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature on-hold This PR or issue may be handled in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a feature to support checks of the GitHub issue tracker
8 participants