Merge pull request #21 from Gavant/pass-options-to-puppeteer

Pass options to puppeteer
Gavant · Jun 8, 2023 · d548ec9 · d548ec9
2 parents 355f743 + 7b689f4
commit d548ec9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/package.json b/package.json
@@ -32,6 +32,7 @@
         "prepare": "yarn build",
         "cli": "ts-node src/cli.ts",
         "test": "tsc -p tsconfig.json && qunit dist/tests/unit/requests/**/*.js && qunit dist/tests/unit/services/pdf-generation.js",
+        "test-all": "tsc -p tsconfig.json && qunit dist/tests/**/*.js",
         "lint": "eslint src/ --ext .js,.ts",
         "build": "tsc -p tsconfig-build.json",
         "clean": "rm -rf dist build",

diff --git a/src/services/pdf-generation.ts b/src/services/pdf-generation.ts
@@ -24,7 +24,8 @@ export default class PdfGenerationService {
         }
         console.log(pdfGenerationRequest);
         await page.goto(pdfGenerationRequest.url, {
-            waitUntil: 'networkidle0'
+            waitUntil: 'networkidle0',
+            ...pdfGenerationRequest.pdfOptions
         });
         console.log(`Puppeteer visited page located at ${pdfGenerationRequest.url}`);
         const options = { ...htmlToPdfPrintOptions, ...pdfGenerationRequest.pdfOptions };