Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert many of the args to kwargs move. Shit happened under the hood. #1624

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

joa-quim
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 91.37931% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.99%. Comparing base (e962a6a) to head (6eb7802).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/common_options.jl 82.14% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
+ Coverage   85.95%   85.99%   +0.03%     
==========================================
  Files         149      149              
  Lines       20769    20768       -1     
==========================================
+ Hits        17853    17859       +6     
+ Misses       2916     2909       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joa-quim joa-quim merged commit f127dab into master Dec 30, 2024
6 of 10 checks passed
@joa-quim joa-quim deleted the integrate-reversions branch December 30, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants