Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pygmt.grdtrack: Simplify the handling of optional virtual files #2708

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 2, 2023

Description of proposed changes

The pygmt.grdtrack method also takes an optional virtual file, so it can be
greatly simplified after #2493.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Oct 2, 2023
@seisman seisman added this to the 0.11.0 milestone Oct 2, 2023
@seisman seisman added enhancement Improving an existing feature and removed maintenance Boring but important stuff for the core devs labels Oct 2, 2023
@seisman seisman requested a review from a team October 2, 2023 14:22
@seisman seisman added the needs review This PR has higher priority and needs review. label Oct 2, 2023
@seisman
Copy link
Member Author

seisman commented Oct 7, 2023

Ping @GenericMappingTools/pygmt-maintainers for reviews.

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now!

Btw, should this be tagged skip-changelog?

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog final review call This PR requires final review and approval from a second reviewer and removed enhancement Improving an existing feature needs review This PR has higher priority and needs review. labels Oct 9, 2023
@seisman seisman merged commit ff155d6 into main Oct 9, 2023
15 checks passed
@seisman seisman deleted the simplify-grdtrack branch October 9, 2023 03:58
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants