-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pygmt.grdtrack: Simplify the handling of optional virtual files #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
enhancement
Improving an existing feature
and removed
maintenance
Boring but important stuff for the core devs
labels
Oct 2, 2023
Ping @GenericMappingTools/pygmt-maintainers for reviews. |
7 tasks
weiji14
reviewed
Oct 8, 2023
weiji14
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good now!
Btw, should this be tagged skip-changelog
?
seisman
added
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
final review call
This PR requires final review and approval from a second reviewer
and removed
enhancement
Improving an existing feature
needs review
This PR has higher priority and needs review.
labels
Oct 9, 2023
seisman
removed
the
final review call
This PR requires final review and approval from a second reviewer
label
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
Boring but important stuff for the core devs
skip-changelog
Skip adding Pull Request to changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
The
pygmt.grdtrack
method also takes an optional virtual file, so it can begreatly simplified after #2493.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.Slash Commands
You can write slash commands (
/command
) in the first line of a comment to performspecific operations. Supported slash commands are:
/format
: automatically format and lint the code/test-gmt-dev
: run full tests on the latest GMT development version