[Fixes: #259] Loading of dataset fails if domain contains geoserver #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@t-book if you agree I would close this PR, since it has conflicts now and the proposed solution doesn't cover the other parts of the same module with the same problem. Your solution might work but it should be put in a method to be reused where needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code splits the URL based on the string geoserver.
In case the domain contains geoserver somewhere else, like https://geoserver.example.com the loading of resources fails.
I'd like to suggest to explitcitly search for /geoserver/ which would target geoserver.example.com /geoserver/ ows...