Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #201] Implement SldFileHandler #203

Merged
merged 15 commits into from
Mar 13, 2024
Merged

[Fixes #201] Implement SldFileHandler #203

merged 15 commits into from
Mar 13, 2024

Conversation

mattiagiupponi
Copy link
Contributor

ref #201

Refactor metadata common and add support for SLD upload.

PS: the PR rely on the implementation of #200 Please review #202 before this

@mattiagiupponi mattiagiupponi self-assigned this Sep 13, 2023
@mattiagiupponi mattiagiupponi linked an issue Sep 13, 2023 that may be closed by this pull request
@mattiagiupponi mattiagiupponi changed the base branch from ISSUE_200 to master September 26, 2023 09:18
importer/handlers/common/metadata.py Outdated Show resolved Hide resolved
importer/handlers/sld/handler.py Outdated Show resolved Hide resolved
importer/handlers/xml/handler.py Outdated Show resolved Hide resolved
Copy link

gitguardian bot commented Mar 7, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
59204 Triggered Django Secret Key 369fce9 .env_test View secret
9468526 Triggered Generic Password 369fce9 entrypoint_test.sh View secret
9468526 Triggered Generic Password 369fce9 .env_test View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

importer/handlers/sld/exceptions.py Outdated Show resolved Hide resolved
@mattiagiupponi mattiagiupponi merged commit b2b038c into master Mar 13, 2024
2 checks passed
@mattiagiupponi mattiagiupponi deleted the ISSUE_201 branch March 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SldFileHandler
2 participants