Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No linebreak in DetailsPanel #1854

Open
ridoo opened this issue Sep 19, 2024 · 5 comments · May be fixed by #1909
Open

No linebreak in DetailsPanel #1854

ridoo opened this issue Sep 19, 2024 · 5 comments · May be fixed by #1909
Assignees

Comments

@ridoo
Copy link

ridoo commented Sep 19, 2024

Describe the bug

On Firefox, long lines of attributes within the Detailspanel do not break. Detailspanel shows an horizontal scrollbar instead. This is different from Chrome.

Firefox:

image

Chrome is ok:

image

Expected Behavior

Lines break the same way as in Chrome Browser

Steps to Reproduce the Problem

  1. Open a dataset having attributes with long lines (browser resize does not resize the detail panel)
    - master: https://stable.demo.geonode.org/catalogue/#/dataset/10913
    - development: https://development.demo.geonode.org/catalogue/#/dataset/583
  2. Open details panel (firefox)
  3. Open details panel (chrome)

Specifications

  • GeoNode client version: master and development
  • Browser: Firefox
  • Installation type (vanilla, geonode-project): demo instances
  • Additional details:
@ridoo
Copy link
Author

ridoo commented Oct 16, 2024

@kilichenko-pixida could you please have a look into it

@kilichenko-pixida
Copy link

kilichenko-pixida commented Oct 22, 2024

@ridoo It seems like the poblem is not with long lines of attributes per se, but specifically with keywords, because they are links. If the title is very long, it seems to wrap around just fine in Firefox as well. And as for the keywords, adding the following css makes it work both in Chrome and Firefox:

.gn-details-info-value > a { display: inline-block; }

My guess is that this particular element styling isn't specified explicitly and Chrome and Firefox just have different default display modes. Unfortunately, I wasn't able to figure out how to actually make changes to front-end and would require some help to actually apply the change.

kilichenko-pixida added a commit to kilichenko-pixida/geonode-mapstore-client that referenced this issue Nov 21, 2024
@kilichenko-pixida kilichenko-pixida linked a pull request Nov 21, 2024 that will close this issue
@kilichenko-pixida
Copy link

Created a PR for it.

@ridoo ridoo linked a pull request Nov 21, 2024 that will close this issue
ridoo pushed a commit to Thuenen-GeoNode-Development/geonode-mapstore-client that referenced this issue Nov 25, 2024
@gannebamm gannebamm reopened this Nov 29, 2024
@ridoo
Copy link
Author

ridoo commented Nov 29, 2024

@gannebamm still an issue or did you re-open this one by accident?

@gannebamm
Copy link

@ridoo It is fixed in our fork, but I haven't tested it on master, yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants