Fixes #1854 (no linebreak in Firefox) #1909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1854.
My best guess is that there is a difference between Firefox and Chrome in how they handle linebreaking for inline elements that have white-space: nowrap property.
Apparantly Chrome allows line breaks between inline elements within a container if the container's width is insufficient to accommodate them on a single line, while Firefox renders it differently and no linebreak occurs with that same property value. If the nowrap value is removed, behaviour would be consistent across those two browsers and wrapping happens.
However, I think this property serves a purpose, it was introduced in this fix for this issue. If the property is removed, regions and keywords would be wrapped on white space, potentially splitting phrases that are only meaningful together onto two lines, which is probably undesirable.
Therefore, my proposed fix makes those elements inline-block, which allows them to wrap as separate boxes and respect the container’s width.