-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #12049] Adapt the SLD and XML upload forms to the new progress API #12050
Conversation
@maabdelghaffar this depends on GeoNode/geonode-importer#230 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #12050 +/- ##
==========================================
- Coverage 63.84% 63.83% -0.02%
==========================================
Files 867 867
Lines 52529 52529
Branches 6568 6568
==========================================
- Hits 33539 33531 -8
- Misses 17468 17476 +8
Partials 1522 1522 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@giohappy it works in sync
but not in async
. The second call for getting the status raises an error (see screenshot). Looks like that from the second call, the execution_data
is empty as is the execution_id
Also, the uploaded XML file, is visible in the dataset upload page, since the attacched source is upload
. In case we dont want to have them listed, we can change source
.
Plus is suggest in case of success
to send a DELETE
call to the execution_id
endpoint to remove the execution id from the list to have a lighter payload
@mattiagiupponi I'm not sure what you mean. If the |
So, the issue was inside the polling, where the execution_id wasn't forwarded to subsequent calls. |
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.