Harvest data from online OJS instances at fixed interval # 47 #87
+287
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
uxairibrar
commented
Feb 13, 2025
uxairibrar
commented
- Configured Django-Q task scheduling to automate harvesting at defined intervals.
- Developed unit tests for task scheduling (test_task_scheduling) and duplicate prevention (test_no_duplicates).
- Created HarvestingEvent model to track harvesting jobs and their statuses.
- Modified the Publication model to support additional metadata.
- Added Django Admin actions for manually triggering harvesting from the admin panel.
uxairibrar
changed the title
nuest
requested changes
Feb 19, 2025
| @@ -35,7 +35,7 @@ | |||
| SECRET_KEY = env('SECRET_KEY', default='django-insecure') | |||
|
|
|||
| # SECURITY WARNING: don't run with debug turned on in production! | |||
| DEBUG = env('OPTIMAP_DEBUG', default=True) | |||
There was a problem hiding this comment.
Please revert this change - we still need to be able to disable debug mode!
| @@ -173,7 +173,7 @@ | |||
| CACHE_MIDDLEWARE_SECONDS = env('OPTIMAP_CACHE_SECONDS', default=3600) | |||
|
|
|||
| # for testing email sending EMAIL_BACKEND = 'django.core.mail.backends.smtp.EmailBackend' | |||
| EMAIL_BACKEND = env('OPTIMAP_EMAIL_BACKEND', default='django.core.mail.backends.console.EmailBackend') | |||
| EMAIL_BACKEND = env('OPTIMAP_EMAIL_BACKEND', default='django.core.mail.backends.smtp.EmailBackend') | |||
There was a problem hiding this comment.
Please revert: for development, we want to keep to console as the default case. Adjust your specific configuration when you work on emails.
| @@ -183,6 +183,8 @@ | |||
| EMAIL_USE_TLS = env('OPTIMAP_EMAIL_USE_TLS', default=False) | |||
| EMAIL_USE_SSL = env('OPTIMAP_EMAIL_USE_SSL', default=False) | |||
| EMAIL_IMAP_SENT_FOLDER = env('OPTIMAP_EMAIL_IMAP_SENT_FOLDER', default='') | |||
| OAI_USERNAME = os.getenv("OAI_USERNAME") | |||
There was a problem hiding this comment.
Please follow the naming scheme of other environment variables.
| time.sleep(2) | ||
| schedule = Schedule.objects.filter(name=f"Harvest Source {source.id}") | ||
| self.assertTrue(schedule.exists(), "Django-Q task not scheduled for source.") |
There was a problem hiding this comment.
Is it possible to actually trigger a harvest here and check the outcome?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.