Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed for all publications #88

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

uxairibrar
Copy link
Collaborator

@uxairibrar uxairibrar commented Feb 13, 2025

Closes #49

  • Implemented GeoRSS feed for publications.
  • Handled Point, Polygon, and GeometryCollection types.
  • Fixed missing georss:point and georss:polygon in RSS output.
  • Overrode add_item_elements() to ensure GeoRSS tags appear in XML.
  • Added GeoRSS namespace (xmlns:georss) for standard compliance.
  • Filtered publications with valid geometry and URLs to prevent errors.
  • Tested and debugged feed output to confirm correct GeoRSS structure

Copy link
Member

@nuest nuest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

To really judge if this is generating output as expected, please add a test case!

tests/test_publications_api.py should be a good starting point. The test should insert some test data (with different geometries) and then check if the created feed content is as expected. You can also store the generated XML in a file as a reference compare the two files, that is also pretty illustrating.

@nuest nuest changed the title Feed for all publications #49 Feed for all publications Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feed for all publications
2 participants