Clear debounce during cleanup useEffect

GeotrekCE · Oct 15, 2024 · 74898ec · 74898ec
1 parent a12d59d
commit 74898ec
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/frontend/src/components/Map/SearchMap/MoveHandler.tsx b/frontend/src/components/Map/SearchMap/MoveHandler.tsx
@@ -26,6 +26,7 @@ const MoveHandler: React.FC<Props> = ({ onMove }) => {
     map.on('moveend', handleMove);
     return () => {
       map.off('moveend', handleMove);
+      handleMove.clear();
     };
   }, [handleMove, map]);
 

diff --git a/frontend/src/components/pages/details/components/DetailsCard/useDetailsCard.tsx b/frontend/src/components/pages/details/components/DetailsCard/useDetailsCard.tsx
@@ -66,6 +66,7 @@ export const useDetailsCard = (hasMedia = false) => {
     debouncedResize();
     global.addEventListener('resize', handleResize);
     return () => {
+      debouncedResize.clear();
       global.removeEventListener('resize', handleResize);
     };
   }, [debouncedResize]);

diff --git a/frontend/src/hooks/useSectionsReferences.ts b/frontend/src/hooks/useSectionsReferences.ts
@@ -1,4 +1,4 @@
-import { useCallback, useRef, useState } from 'react';
+import { useCallback, useMemo, useRef, useState } from 'react';
 import { DetailsSections, DetailsSectionsPosition } from 'components/pages/details/useDetails';
 import debounce from 'debounce';
 import { getDimensions } from 'components/pages/details/utils';
@@ -22,7 +22,7 @@ const useSectionsReferences = () => {
       [sectionName],
     );
 
-  const handleResize = useCallback(
+  const handleResize = useMemo(
     () =>
       debounce(
         () => {
@@ -49,6 +49,7 @@ const useSectionsReferences = () => {
     global.addEventListener('resize', handleResize);
     global.addEventListener('scroll', handleResize);
     return () => {
+      handleResize.clear();
       global.removeEventListener('resize', handleResize);
       global.removeEventListener('scroll', handleResize);
     };