Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build "Show More" menu items only if there are enough #1296

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

dtrucs
Copy link
Collaborator

@dtrucs dtrucs commented Oct 29, 2024

The “show more” menu button is added when there are no hierarchical items in menuItems. It takes the primaryItemsNumber parameters defined in header.json to divide the menu.

But when the list of items is less than primaryItemsNumber value, the show more button appears without any sub-items.

@dtrucs dtrucs requested a review from a team October 29, 2024 10:34
@dtrucs dtrucs merged commit dd3acb4 into develop Oct 29, 2024
2 checks passed
@dtrucs dtrucs deleted the Build-show-more-menu-items-only-if-there-are-enough branch October 29, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants