Skip to content

Commit

Permalink
[kde] Move the KIO service menu for KF5/KF6 from kf5/ to kde/.
Browse files Browse the repository at this point in the history
This service menu is used for both KF5 and KF6.

[debian] New package rom-properties-kio-servicemenus, which is
now selected by rom-properties-kf5. rom-properties-kf5 no longer
installs the service menu file.

TODO: Verify that the Conflicts: and Replaces: rules work correctly.
  • Loading branch information
GerbilSoft committed Feb 18, 2024
1 parent 8428856 commit 8d76641
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 14 deletions.
14 changes: 13 additions & 1 deletion debian/control
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,21 @@ Description: ROM Properties Page shell extension
.
This package contains the KDE 4 version.

Package: rom-properties-kio-servicemenus
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, libromdata4, rom-properties-utils
Conflicts: rom-properties-kf5 (< 2.3)
Replaces: rom-properties-kf5 (< 2.3)
Description: ROM Properties Page shell extension
This shell extension provides thumbnailing and property page functionality
for ROM images, disc images, and save files for various game consoles,
including Nintendo GameCube and Wii.
.
This package contains the KIO service menus for KF5 and KF6.

Package: rom-properties-kf5
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, libromdata4, rom-properties-utils, rom-properties-xdg
Depends: ${shlibs:Depends}, ${misc:Depends}, libromdata4, rom-properties-utils, rom-properties-xdg, rom-properties-kio-servicemenus
Recommends: rom-properties-lang
Conflicts: rom-properties-kde5
Replaces: rom-properties-kde5
Expand Down
5 changes: 5 additions & 0 deletions debian/rom-properties-kio-servicemenus.docs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
README.md
NETWORK.md
NEWS.md
doc/keys.conf.example
doc/rom-properties.conf.example
1 change: 1 addition & 0 deletions debian/rom-properties-kio-servicemenus.install
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
usr/share/kio/servicemenus/rp-convert-to-png.desktop
9 changes: 9 additions & 0 deletions src/kde/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,15 @@ IF(BUILD_KF6)
ADD_SUBDIRECTORY(kf6)
ENDIF(BUILD_KF6)

IF(BUILD_KF5 OR BUILD_KF6)
# Service menus
# KF5 and KF6 use the same servicemenus directory.
INSTALL(FILES servicemenus/rp-convert-to-png.desktop
DESTINATION "${CMAKE_INSTALL_PREFIX}/share/kio/servicemenus"
PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
COMPONENT "plugin")
ENDIF(BUILD_KF5 OR BUILD_KF6)

IF(BUILD_TESTING)
ADD_SUBDIRECTORY(tests)
ENDIF(BUILD_TESTING)
6 changes: 0 additions & 6 deletions src/kde/kf5/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -288,12 +288,6 @@ IF(BUILD_KF5)
ENDIF(NOT HAVE_JSON_PLUGIN_LOADER)
# FIXME: Run kbuildsycoca5?

# Service menus
INSTALL(FILES ../servicemenus/rp-convert-to-png.desktop
DESTINATION "${CMAKE_INSTALL_PREFIX}/share/kio/servicemenus"
PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
COMPONENT "plugin")

# Check if a split debug file should be installed.
IF(INSTALL_DEBUG)
# FIXME: Generator expression $<TARGET_PROPERTY:${_target},PDB> didn't work with CPack-3.6.1.
Expand Down
7 changes: 0 additions & 7 deletions src/kde/kf6/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -252,13 +252,6 @@ IF(BUILD_KF6)
COMPONENT "plugin")
# FIXME: Run kbuildsycoca6?

# Service menus
# FIXME: Conflicts with KF6. Figure out how to fix this later.
#INSTALL(FILES ../servicemenus/rp-convert-to-png.desktop
# DESTINATION "${CMAKE_INSTALL_PREFIX}/share/kio/servicemenus"
# PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE GROUP_READ GROUP_EXECUTE WORLD_READ WORLD_EXECUTE
# COMPONENT "plugin")

# Check if a split debug file should be installed.
IF(INSTALL_DEBUG)
# FIXME: Generator expression $<TARGET_PROPERTY:${_target},PDB> didn't work with CPack-3.6.1.
Expand Down

0 comments on commit 8d76641

Please sign in to comment.