eng(sqlite): update analysis_options of SqliteProvider #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![jit-ci[bot]](https://avatars.githubusercontent.com/in/142441?s=60&v=4){kind=small}
mateominato
approved these changes
Dec 16, 2024
| @@ -175,20 +182,25 @@ class QuerySqlTransformer<_Model extends SqliteModel> { | |||
| } | |||
| } | |||
|
|
|||
| /// Inner joins | |||
| /// Inner joins; not for public use | |||
There was a problem hiding this comment.
if it's internal only, should you use one of dart's fancy class keywords? like final?
There was a problem hiding this comment.
Brick 3 still supports Dart 2.18 and up; fancy keywords weren't available until Dart 3.
That said, I really like this idea, and I'm definitely going to do it for Brick 4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.