[AND-250] Add separate text resource for "Add an option" placeholder.

GetStream · Jan 16, 2025 · 681944c · 681944c
1 parent 81af35f
commit 681944c
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/...ain/java/io/getstream/chat/android/compose/ui/messages/attachments/poll/PollOptionList.kt b/...ain/java/io/getstream/chat/android/compose/ui/messages/attachments/poll/PollOptionList.kt
@@ -136,7 +136,7 @@ public fun PollOptionList(
                     PollOptionInput(
                         modifier = Modifier.weight(1f),
                         value = item.title,
-                        description = stringResource(id = R.string.stream_compose_poll_option_description),
+                        description = stringResource(id = R.string.stream_compose_poll_option_placeholder),
                         innerPadding = if (item.pollOptionError == null) {
                             PaddingValues(horizontal = 16.dp, vertical = 18.dp)
                         } else {

diff --git a/stream-chat-android-compose/src/main/res/values/strings.xml b/stream-chat-android-compose/src/main/res/values/strings.xml
@@ -207,6 +207,7 @@
     <string name="stream_compose_poll_questions_description" translatable="false">Ask a question</string>
     <string name="stream_compose_poll_option_title" translatable="false">Options</string>
     <string name="stream_compose_poll_option_description" translatable="false">Add an option</string>
+    <string name="stream_compose_poll_option_placeholder" translatable="false">Add an option</string>
     <string name="stream_compose_poll_option_error_duplicated" translatable="false">This is already an option</string>
     <string name="stream_compose_poll_option_error_exceed" translatable="false">Type a number under %d</string>
     <string name="stream_compose_poll_option_discard_dialog_title" translatable="false">Discard poll</string>

diff --git a/stream-chat-android-ui-components/src/main/res/layout/stream_ui_poll_option.xml b/stream-chat-android-ui-components/src/main/res/layout/stream_ui_poll_option.xml
@@ -23,7 +23,7 @@
         android:id="@+id/option"
         android:layout_width="match_parent"
         android:layout_height="56dp"
-        android:hint="@string/stream_ui_poll_add_an_option_label"
+        android:hint="@string/stream_ui_poll_add_an_option_placeholder"
         android:layout_marginTop="@dimen/stream_ui_spacing_small"
         android:padding="@dimen/stream_ui_spacing_small"
         android:gravity="center_vertical"

diff --git a/stream-chat-android-ui-components/src/main/res/values/strings.xml b/stream-chat-android-ui-components/src/main/res/values/strings.xml
@@ -18,7 +18,8 @@
     <string name="stream_ui_poll_question_label">Question</string>
     <string name="stream_ui_poll_ask_a_question_hint">Ask a question</string>
     <string name="stream_ui_poll_options_label">Options</string>
-    <string name="stream_ui_poll_add_an_option_label">Add an Option</string>
+    <string name="stream_ui_poll_add_an_option_label">Add an option</string>
+    <string name="stream_ui_poll_add_an_option_placeholder">Add an option</string>
     <string name="stream_ui_poll_multiple_answers_label">Multiple answers</string>
     <string name="stream_ui_poll_max_number_of_answers_hint">Max number of answers</string>
     <string name="stream_ui_poll_anonymous_poll_label">Anonymous poll</string>