Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i110] control options icon for each channel #4928

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Aug 18, 2023

🎯 Goal

Closes: https://github.com/GetStream/android-internal-board/issues/110

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

kanat added 3 commits August 18, 2023 08:41
(cherry picked from commit 5d79022)

# Conflicts:
#	stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/channel/list/adapter/viewholder/ChannelListIconProviderContainer.kt
#	stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/channel/list/adapter/viewholder/ChannelListIconProviderContainerImpl.kt
#	stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/channel/list/internal/SimpleChannelListView.kt
@kanat kanat changed the title Task/channel options icon [i110] control options icon for each channel Aug 18, 2023
@kanat kanat marked this pull request as ready for review August 18, 2023 16:20
@kanat kanat requested a review from a team as a code owner August 18, 2023 16:20
@kanat kanat added enhancement New feature or request ui-components v5 labels Aug 18, 2023
@kanat kanat merged commit be7bb99 into v5 Aug 18, 2023
@kanat kanat deleted the task/channel-options-icon branch August 18, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant