Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ui-tests) fix broken ui-tests #4935

Merged
merged 3 commits into from
Aug 29, 2023
Merged

(ui-tests) fix broken ui-tests #4935

merged 3 commits into from
Aug 29, 2023

Conversation

kanat
Copy link
Collaborator

@kanat kanat commented Aug 25, 2023

🎯 Goal

UI-tests got broken due to these changes: #4893

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@kanat kanat marked this pull request as ready for review August 25, 2023 22:49
@kanat kanat requested a review from a team as a code owner August 25, 2023 22:49
@kanat kanat added the tests label Aug 25, 2023
@kanat kanat merged commit 25a604c into develop Aug 29, 2023
7 checks passed
@kanat kanat deleted the v6/ui-tests branch August 29, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant