Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-25] Threads V2 offline support #5481

Merged
merged 88 commits into from
Nov 20, 2024
Merged

[AND-25] Threads V2 offline support #5481

merged 88 commits into from
Nov 20, 2024

Conversation

VelikovPetar
Copy link
Contributor

🎯 Goal

The PR includes 2 significant changes:

  • Fixes the handling of the NotificationMarkUnread event, which now correctly delivers a threadId, if the event is delivered when marking a thread
  • Introduces offline support for the thread list

🛠 Implementation details

  1. Introduce ThreadEntity - DB model for the domain Thread model.
  2. Introduce ThreadOrderEntity - DB model which persists the order of the threads as initially delivered from BE (we don't know the exact sorting the BE does, so this is a way of persisting the same order)
  3. Introduce ThreadDao and ThreadOrderDao for DB interaction
  4. Introduce ThreadRepository with two implementations: DatabaseThreadRepository and the fallback NoOpThreadRepository
  5. Introduce QueryThreadsListenerDatabase which inserts thread data into the DB after every successful HTTP queryThreads() call.
  6. Enhance QueryThreadsLogic to pre-populate the QueryThreadsState with previously fetched offline data
  7. Update threads DB data on relevant web socket events: NewMessageEvent, DeleteMessageEvent, UpdateMessageEvent, ReactionNewEvent, ReactionUpdatedEvent, ReactionDeletedEvent, MessageReadEvent, NotificationMarkUnreadEvent
  8. Update RepositoryFacade to ensure thread data is updated when calling insertMessage, insertMessages or deleteChannel
  9. Extract some common Thread update methods such as updateParent/upsertReply/... to client.extensions.internal.Thread file

🧪 Testing

  1. Install compose sample app
  2. Open Threads tab
  3. Close app
  4. Turn connectivity off
  5. Open Threads tab
  6. Open/Edit/Add/Delete messages by opening the thread

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

PetarVelikov added 30 commits October 9, 2024 09:32
[PBE-3749] Update ThreadsApi to match the definition.
b83a7bc
[PBE-3749] Register "notification.thread_message_new" EventType.
9ac769b
Merge branch 'refs/heads/develop' into feature/threads_v2
c5187ae
[PBE-3749] Implement initial state-management for 'Query Threads'.
e338150
[PBE-3749] Implement ThreadList component.
ce4ab6d
Merge branch 'refs/heads/develop' into feature/threads_v2
8d30835
[PBE-3749] Implement 'Threads' tab in compose sample app.
fdb1ac1
[PBE-3749] FIx pagination logic and add a threshold.
13400dc
[PBE-3749] Add queryThreads preconditions checks.
7a44105
[PBE-3749] Revert ktlint commit.
7ccf42b
[PBE-3749] Remove redundant state update in ThreadListController.
7bf4d3f
[PBE-3749] Add handling for different ChatEvents.
c058190
Merge branch 'refs/heads/develop' into feature/threads_v2
8486cde
[PBE-3749] Remove redundant coroutine creation and docs.
361e754
[PBE-3749] Fix detekt and spotless.
2e8c1b1
Revert "[PBE-3749] Implement 'Threads' tab in compose sample app."
fbc9b3d 
This reverts commit fdb1ac1
Revert "Revert "[PBE-3749] Implement 'Threads' tab in compose sample …
cd01294 
…app.""

This reverts commit fbc9b3d.
Revert "[PBE-3749] Implement 'Threads' tab in compose sample app."
b856073 
This reverts commit fdb1ac1
[PBE-3749] Hide threads-related public apis.
76e5f54
Merge branch 'refs/heads/develop' into feature/threads_v2
6fc64d8 
# Conflicts:
#	stream-chat-android-compose/src/main/res/values/strings.xml
[PBE-3749] Fix PR remarks related DTOs.
b88eca7
[PBE-3749] Fix wrong composable preview.
b91a89c
[PBE-3749] Use inheritScope to create ThreadListController coroutine …
3560186 
…scope.
Merge branch 'refs/heads/develop' into feature/threads_v2
de906ea
[PBE-3749] Implement ChatClient::markThreadRead operation.
72d3689
[PBE-3749] Update CHANGELOG for markThreadRead.
10e5c9d
[PBE-3749] Fix failing test.
93f8f39
[PBE-3749] Separate markThreadRead from markRead.
0b7d384
[PBE-3749] Implement unreadThreads logic as part of the GlobalState.
321907f
Merge branch 'refs/heads/develop' into feature/threads_v2_global_unre…
47e7849 
…ad_threads_state
PetarVelikov added 22 commits October 30, 2024 14:04
[PBE-3749] Add ThreadList to CHANGELOG and add docusaurus documentation
fcfd281 
.
[PBE-3749] Ensure threads state is updated on different client operat…
88a1f05 
…ions.
[PBE-3749] Fix failing tests.
ecae6d1
Merge branch 'refs/heads/develop' into feature/threads_v2
5c7c963
Merge branch 'refs/heads/feature/threads_v2' into feature/threads_v2_…
564666f 
…improvements
Merge branch 'refs/heads/develop' into feature/threads_v2_improvements
c58e458
[PBE-3749] Add 'Mark thread as unread' handling.
a823a89
Merge branch 'refs/heads/develop' into feature/threads_v2
e153761
Merge branch 'refs/heads/feature/threads_v2' into feature/threads_v2_…
b159d5c 
…improvements
Merge branch 'refs/heads/develop' into feature/threads_v2
aec80bb
Merge branch 'refs/heads/feature/threads_v2' into feature/threads_v2_…
acca8de 
…improvements
Merge branch 'refs/heads/develop' into feature/threads_v2
a317992
Merge branch 'refs/heads/feature/threads_v2' into feature/threads_v2_…
6ade7ba 
…improvements
[PBE-3749] Add Threads offline support.
5f0aa68
Merge branch 'develop' into feature/threads_v2
7941d4e 
# Conflicts:
#	stream-chat-android-compose/api/stream-chat-android-compose.api
[PBE-3749] apply spotless.
55e71f8
Merge branch 'feature/threads_v2' into feature/threads_v2_improvements
e52aede
Merge branch 'feature/threads_v2_improvements' into feature/threads_o…
3acbf81 
…ffline
Merge branch 'develop' into feature/threads_offline
281c47a 
# Conflicts:
#	CHANGELOG.md
#	docusaurus/sidebars-android.js
#	stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/mapping/ThreadMapping.kt
#	stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/model/dto/ThreadDtos.kt
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/threads/ThreadItem.kt
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/threads/ThreadList.kt
#	stream-chat-android-core/api/stream-chat-android-core.api
#	stream-chat-android-core/src/main/java/io/getstream/chat/android/models/ThreadInfo.kt
#	stream-chat-android-core/src/main/java/io/getstream/chat/android/models/ThreadParticipant.kt
#	stream-chat-android-state/src/main/java/io/getstream/chat/android/state/plugin/logic/internal/LogicRegistry.kt
#	stream-chat-android-state/src/main/java/io/getstream/chat/android/state/plugin/logic/querythreads/internal/QueryThreadsLogic.kt
#	stream-chat-android-state/src/main/java/io/getstream/chat/android/state/plugin/logic/querythreads/internal/QueryThreadsStateLogic.kt
#	stream-chat-android-state/src/test/java/io/getstream/chat/android/state/plugin/logic/querythreads/internal/QueryThreadsLogicTest.kt
#	stream-chat-android-state/src/test/java/io/getstream/chat/android/state/plugin/logic/querythreads/internal/QueryThreadsStateLogicTest.kt
#	stream-chat-android-state/src/test/java/io/getstream/chat/android/state/plugin/state/querythreads/internal/QueryThreadsMutableStateTest.kt
[PBE-3749] Post-merge clean-up.
38655a5
[PBE-3749] Remove docs.
086d9cb
[PBE-3749] Update NotificationMarkUnreadEvent with threadId for threa…
29e66d2 
…d events.
@github-actions GitHub Actions
Copy link
Contributor

DB Entities have been updated. Do we need to upgrade DB Version?
Modified Entities :

stream-chat-android-offline/src/main/java/io/getstream/chat/android/offline/repository/domain/threads/internal/ThreadEntity.kt
stream-chat-android-offline/src/main/java/io/getstream/chat/android/offline/repository/domain/threads/internal/ThreadOrderEntity.kt

@VelikovPetar VelikovPetar marked this pull request as ready for review November 20, 2024 11:33
@VelikovPetar VelikovPetar requested a review from a team as a code owner November 20, 2024 11:33
@JcMinarro JcMinarro merged commit f06acf7 into develop Nov 20, 2024
9 checks passed
@JcMinarro JcMinarro deleted the feature/threads_offline branch November 20, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VelikovPetar @JcMinarro