[AND-14] Refactor Channel.lastMessageAt logic
#5488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JcMinarro
force-pushed
the
refactor/last-message-at
branch
from
417360c
to
88578ec
Compare
...droid-client/src/main/java/io/getstream/chat/android/client/parser2/adapters/EventAdapter.kt
Outdated
Show resolved
Hide resolved
...android-client/src/main/java/io/getstream/chat/android/client/api2/mapping/ChannelMapping.kt
Show resolved
Hide resolved
JcMinarro
force-pushed
the
refactor/last-message-at
branch
from
88578ec
to
3f0899d
Compare
VelikovPetar
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Previously the SDK was calculating the date of the last message within the channel, but it could cause errors due to deleted messages, system messages or some configuration that shouldn't be counted for this calculation.
The backend is calculating this value and sending it us on events that could update the content of the channel itself.
🎉 GIF