Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-146] Intercept Attachment Download Process #5490

Merged
merged 7 commits into from
Nov 29, 2024

Conversation

JcMinarro
Copy link
Member

🎯 Goal

Provide some dependencies to allow intercepting the Attachemnt Download Process.
The DownloadAttachmentUriGenerator dependency allows our customers to build a custom url for the attaachment.
The DownloadRequestInterceptor dependency allows our customers to apply extra data on the DownloadManager.Request used to download the attachment

The Integration is added on the ChatUI and/or ChatTheme instances.

UI-Components:

ChatUI.downloadAttachmentUriGenerator = [....]
ChatUI.downloadRequestInterceptor = [...]

Compose UI:

ChatTheme(
  [...],
  downloadAttachmentUriGenerator = [...],
  downloadRequestInterceptor = [...],
)

🎉 GIF

@JcMinarro JcMinarro requested review from VelikovPetar and a team November 27, 2024 12:33
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me!

@JcMinarro JcMinarro force-pushed the feature/intercept-attachment-download-request branch from 28a626f to d47ba89 Compare November 28, 2024 09:17
@JcMinarro JcMinarro force-pushed the feature/intercept-attachment-download-request branch from d47ba89 to dd8135d Compare November 29, 2024 11:10
@JcMinarro JcMinarro enabled auto-merge (squash) November 29, 2024 11:11
@JcMinarro JcMinarro merged commit 2c7fdaa into develop Nov 29, 2024
9 checks passed
@JcMinarro JcMinarro deleted the feature/intercept-attachment-download-request branch November 29, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants