Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AND-151] Improve attachment factories #5494

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

JcMinarro
Copy link
Member

🎯 Goal

Provide a list of non-deseired type of Attachment Factories to easily filter out from our default factories and allow our AudioRecord Attachment to be played from the local recording on the case the url is not ready yet

🎉 GIF

@JcMinarro JcMinarro requested a review from a team as a code owner November 29, 2024 11:18
@JcMinarro JcMinarro force-pushed the feature/improve-attachment-factories branch from dc72d7d to 592954e Compare November 29, 2024 15:52
Copy link
Contributor

@VelikovPetar VelikovPetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment, but otherwise looks good to me!

@JcMinarro JcMinarro enabled auto-merge (squash) December 5, 2024 13:24
@JcMinarro JcMinarro force-pushed the feature/improve-attachment-factories branch from 592954e to 7be8c78 Compare December 5, 2024 13:24
@JcMinarro JcMinarro merged commit 731832d into develop Dec 5, 2024
9 checks passed
@JcMinarro JcMinarro deleted the feature/improve-attachment-factories branch December 5, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants