Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/gradle-optimization #5496

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

icanerdogan
Copy link

@icanerdogan icanerdogan commented Dec 1, 2024

🎯 Goal

To convert the build.gradle files to build.gradle.kts for better type safety, auto-completion, and maintainability within the Stream Chat Android project.

🛠 Implementation Details

  • Replaced all existing build.gradle files with their Kotlin DSL equivalents (build.gradle.kts).
  • Updated build script dependencies and configurations to align with Kotlin DSL syntax.
  • Ensured compatibility with the current project structure and dependencies.
  • Verified that all Gradle tasks (e.g., build, test, lint) work seamlessly after the migration.

🎨 UI Changes

No UI changes are introduced in this pull request.

Before After
N/A N/A

🧪 Testing

  • Validated the migration by running the following Gradle tasks:
    • ./gradlew build
    • ./gradlew test
    • ./gradlew lint
  • Confirmed that the project compiles and runs successfully.
  • Manually tested key modules to ensure proper functionality.
Patch Summary
// Example snippet from the updated `build.gradle.kts` file

plugins {
    id("com.android.application")
    kotlin("android")
    kotlin("kapt")
}

android {
    compileSdk = 33

    defaultConfig {
        applicationId = "com.example.streamchat"
        minSdk = 21
        targetSdk = 33
        versionCode = 1
        versionName = "1.0"
    }

    // More configurations...
}

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@icanerdogan icanerdogan requested a review from a team as a code owner December 1, 2024 14:12
@icanerdogan icanerdogan changed the title stream-chat-android-client build.gradle converted kts. refactor/gradle-optimization Dec 1, 2024
@icanerdogan icanerdogan changed the base branch from main to develop December 1, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant