Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-16] Implement ChatClient.partialUpdateMember() #5497

Merged
merged 4 commits into from
Dec 3, 2024
Merged

[AND-16] Implement ChatClient.partialUpdateMember() #5497

merged 4 commits into from
Dec 3, 2024

Conversation

VelikovPetar
Copy link
Contributor

🎯 Goal

Implements the partialUpdateMember operation.

🛠 Implementation details

  • Extend Member, UpstreamMemberDto, DownstreamMemberDto and MemberEntity with custom data.
  • Write new extra data adapters for the DTOs
  • Add custom data validation in ExtraDataValidator for reserved Member field names
  • Add partialUpdateMember to ChannelApi
  • Expose partialUpdateMember on ChatClient and ChannelClient

@VelikovPetar VelikovPetar marked this pull request as ready for review December 2, 2024 16:30
@VelikovPetar VelikovPetar requested a review from a team as a code owner December 2, 2024 16:30
@VelikovPetar VelikovPetar marked this pull request as draft December 2, 2024 16:41
@VelikovPetar VelikovPetar marked this pull request as ready for review December 3, 2024 08:08
@aleksandar-apostolov aleksandar-apostolov merged commit 09b3b6e into develop Dec 3, 2024
9 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the feature/implement_partial_update_member branch December 3, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandar-apostolov aleksandar-apostolov aleksandar-apostolov approved these changes

@JcMinarro JcMinarro Awaiting requested review from JcMinarro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VelikovPetar @aleksandar-apostolov