fix: allow configuring asset path for icons #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuperaz
commented
May 9, 2024
| $assetsPath: '../../assets' !default; | ||
| @use 'variables'; | ||
|
|
||
| $assetsPath: variables.$assetsPath !default; |
There was a problem hiding this comment.
Avoids breaking change, and lets integrators to keep using the existing sytnax: @use 'stream-chat-<SDK anme>/../emoji-replacement' with ($assetsPath: '../../../../assets');
szuperaz
requested review from
MartinCupela,
arnautov-anton,
myandrienko and
oliverlaz
oliverlaz
approved these changes
May 9, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 9, 2024
## [4.16.1](v4.16.0...v4.16.1) (2024-05-09) ### Bug Fixes * allow configuring asset path for icons ([#295](#295)) ([cdd927f](cdd927f))
|
🎉 This PR is included in version 4.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
If an integrator does a custom style bundling (instead of importing the
index.scss) they might need to set a custom asset path🛠 Implementation details
Provide a description of the implementation
🎨 UI Changes
Add relevant screenshots
Make sure to test with both Angular and React (with both
MessageListandVirtualizedMessageListcomponents) SDKs