Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ConnectionTestCommand more foolproof #3951

Merged
merged 13 commits into from
Sep 6, 2023
Merged

make ConnectionTestCommand more foolproof #3951

merged 13 commits into from
Sep 6, 2023

Conversation

onebeastchris
Copy link
Member

@onebeastchris onebeastchris commented Jul 8, 2023 •
edited
Loading

With this changes, the connectiontest command should be less confusing:

  • it doesnt run the check with placeholders (e.g. in support: <ip>:<port>), or doesnt error out when port is not a number
  • tries to filter out local ips and notifies that the command checks connections from other networks
  • if no port was supplied, the ports not matching message was confusing
  • catch FileNotFoundException that is returned for invalid IPs

@onebeastchris onebeastchris added the PR: Optimization When a PR doesn't necessarily add anything new or fix anything, but improves upon the code label Jul 23, 2023
@onebeastchris onebeastchris mentioned this pull request Sep 5, 2023
Merged
22 tasks
@Konicai Konicai merged commit 0d5cb51 into GeyserMC:master Sep 6, 2023
1 check passed
@onebeastchris onebeastchris deleted the foolproof-connectiontest branch September 6, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtm516 rtm516 rtm516 left review comments

@Konicai Konicai Konicai approved these changes

@Camotoy Camotoy Camotoy approved these changes

Assignees
No one assigned
Labels
PR: Optimization When a PR doesn't necessarily add anything new or fix anything, but improves upon the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onebeastchris @rtm516 @Camotoy @Konicai