Feature: Allow client-side "game settings" menu gamemode/difficulty changes #4062
+169
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Camotoy
reviewed
Aug 25, 2023
...mc/geyser/translator/protocol/bedrock/entity/player/BedrockSetDefaultGameTypeTranslator.java
Outdated
Show resolved
Hide resolved
Camotoy
reviewed
Aug 25, 2023
...eysermc/geyser/translator/protocol/bedrock/entity/player/BedrockSetDifficultyTranslator.java
Outdated
Show resolved
Hide resolved
…ty/default game mode Remove duplicate settings in SettingsUtils - otherwise, they clash with the new translator Prevent client Gamemode switching when personal Gamemode is "default"
|
Updated to address review; discovered slight issue: |
Konicai
requested changes
Sep 2, 2023
...rmc/geyser/translator/protocol/bedrock/entity/player/BedrockSetPlayerGameTypeTranslator.java
Show resolved
Hide resolved
Fabric method to get servers default Gamemode
rtm516
approved these changes
Sep 6, 2023
|
Converted to draft; just got this |
…, optimize getting the default GameMode on Fabric
|
Okay fixed, just re-tested |
Konicai
approved these changes
Sep 8, 2023
Co-authored-by: Konicai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3451
For reference:
This PR would mirror what's done with the
/geyser settingscommand/the server settings tab. Currently, this would effectively double them, can be removed here too or kept in until later. With #3958 on the horizon, i would be in favor of not adding settings in the custom settings menu that already exist, just so extension preferences don't overload the settings page.Regarding gamerules: I would keep those separate, since Bedrock does not offer many of the Java edition gamerules (and a split of implementing some here/some there would be confusing).