Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Nametags not showing up after respawn #4445

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix: Nametags not showing up after respawn #4445

merged 1 commit into from
Feb 15, 2024

Conversation

byquanton
Copy link
Contributor

@byquanton byquanton commented Feb 15, 2024 •
edited
Loading

Resetting the NAMETAG_ALWAYS_SHOW metadata in updateDisplayName seems to fix the issue.

Fixes #4444

onebeastchris
onebeastchris approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Just curious, do nametags on armor stands show up properly in your case?

@byquanton
Copy link
Contributor Author

image

yes (the nametag in the background is from a text display)

@onebeastchris
Copy link
Member

Neat, I somehow thought that it was broken.. Thanks for the confirmation.

@onebeastchris onebeastchris merged commit e97258f into GeyserMC:master Feb 15, 2024
1 check passed
@byquanton byquanton mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onebeastchris onebeastchris onebeastchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Player Nametags Disappear upon death.
2 participants
@byquanton @onebeastchris