Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System property to silence connection attempts #4545

Closed
wants to merge 1 commit into from

Conversation

Kas-tle
Copy link
Member

@Kas-tle Kas-tle commented Apr 3, 2024

No description provided.

@onebeastchris
Copy link
Member

LGTM - please also document this on the wiki

@ShayBox
Copy link

ShayBox commented Apr 3, 2024

Correct me if I'm wrong, but I don't think System.getProperty pulls from the config.yml, this should probably be a config setting that's disabled by default like Spigot and Paper do for Java connections, because this spam is probably going to continue forever.

@Kas-tle
Copy link
Member Author

Kas-tle commented Apr 3, 2024

We will not make this a config option at this time as it would make it too difficult to diagnose issues where the client is unable to connect due to traffic making its way to the server, but not coming back. I will try to do a another PR later that reduces the spam by grouping spammed connection attempts from the same IP into a single log message.

In the future we may also consider replacing system property only configuration with an "advanced config".

@Kas-tle
Copy link
Member Author

Kas-tle commented Apr 7, 2024

Closing in favor of #4554.

@Kas-tle Kas-tle closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants