Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improved parser for issue numbers #160

Merged
merged 4 commits into from
Dec 23, 2024
Merged

perf: Improved parser for issue numbers #160

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e12001
perf: Using `std::cell::LazyCell` to compile Regex
m1sk9 Dec 23, 2024
88c18bb
refactor: Remove `unwrap()` from `caps.get(1)`
m1sk9 Dec 23, 2024
28fae61
refactor: Variable is changed to inline
m1sk9 Dec 23, 2024
e2fb75c
refactor: change error handling to `if-else`
m1sk9 Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/parsers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,20 @@ pub fn parse_embed(embed: &serenity::all::Embed) -> anyhow::Result<IdeaEmbed, Pa
}

fn parse_issue_number(title: &str) -> anyhow::Result<u16, ParseEnvIDsError> {
let re = match regex::Regex::new(r"#(\d+)") {
Ok(regex) => regex,
Err(why) => return Err(ParseEnvIDsError::FailedToParseIssueNumber(why.to_string())),
};
let re = std::cell::LazyCell::new(|| regex::Regex::new(r"#(\d+)").unwrap());

match re.captures(title) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ついでにこれもlet-elseのほうが良さそう

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あとでやっとく

Some(caps) => match caps.get(1).unwrap().as_str().parse::<u16>() {
Ok(num) => Ok(num),
Err(why) => Err(ParseEnvIDsError::FailedToParseIssueNumber(why.to_string())),
},
Some(caps) => {
let Some(matched) = caps.get(1) else {
return Err(ParseEnvIDsError::FailedToParseIssueNumber(
"Failed to get capture group.".to_string(),
));
};
match matched.as_str().parse::<u16>() {
Ok(num) => Ok(num),
Err(why) => Err(ParseEnvIDsError::FailedToParseIssueNumber(why.to_string())),
}
}
None => Err(ParseEnvIDsError::FailedToParseIssueNumber(
"No captures found.".to_string(),
)),
Expand Down
Loading