Merge pull request #38 from lucab/ups/globwalker-next-path-ref

globwalker: avoid spurious allocations in iterator
Gilnaa · Jan 6, 2024 · 7c4465b · 7c4465b
2 parents 96bd5ef + 8528c5a
commit 7c4465b
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -378,14 +378,10 @@ impl Iterator for GlobWalker {
                         // able to recognize the file name.
                         // `unwrap` here is safe, since walkdir returns the files with relation
                         // to the given base-dir.
-                        let path = e
-                            .path()
-                            .strip_prefix(self.ignore.path())
-                            .unwrap()
-                            .to_owned();
+                        let path = e.path().strip_prefix(self.ignore.path()).unwrap();
 
                         // The path might be empty after stripping if the current base-directory is matched.
-                        if let Some("") = path.to_str() {
+                        if path.as_os_str().is_empty() {
                             continue 'skipper;
                         }